Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: type ahead list box ......................................................................
Patch Set 8: (1 inline comment) The template is added to the header in http://gerrit.ovirt.org/#/c/15011 so I will do the mentioned reorder in that patch. .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java Line 19: Line 20: /** Line 21: * Base SuggestBox widget that adapts to UiCommon list model items. Line 22: */ Line 23: public abstract class BaseListModelSuggestBox<T> extends Composite implements EditorWidget<T, TakesConstrainedValueEditor<T>>, HasConstrainedValue<T> { OK, just found out the reason :) The problem is, that the SuggestBox implements the HasValue<String> but I need this class to implement HasConstrainedValue<T> which is a child of HasValue<T>. So this class can not extend the SuggestBox directly. This way it is adapted to edit any model, not just Strings. Line 24: Line 25: private TakesConstrainedValueEditor<T> editor; Line 26: Line 27: private T value; -- To view, visit http://gerrit.ovirt.org/14936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956af3c675894c850a1a104a81cec49f4bd62011 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
