Moti Asayag has posted comments on this change.
Change subject: engine: Added checks for external networks
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkValidatorTest.java
Line 15: import
org.ovirt.engine.core.bll.network.dc.UpdateNetworkCommand.UpdateNetworkValidator;
Line 16: import org.ovirt.engine.core.common.businessentities.network.Network;
Line 17: import
org.ovirt.engine.core.common.businessentities.network.ProviderNetwork;
Line 18: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 19:
There is a positive case missing of updating a network which has no provider,
Line 20: @RunWith(MockitoJUnitRunner.class)
Line 21: public class UpdateNetworkValidatorTest {
Line 22:
Line 23: @Mock
--
To view, visit http://gerrit.ovirt.org/13568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a02f3caffa5b2d1d36e908f79db0c788fff5a8f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
