Yair Zaslavsky has uploaded a new change for review. Change subject: core: Formatting of some classes at dal ......................................................................
core: Formatting of some classes at dal Change-Id: I1719a0e300cba9bd5462685cde36a9dd3232a4e8 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java 2 files changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/15341/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java index 86e51ea..54e46cc 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java @@ -13,21 +13,22 @@ public interface DbEngineDialect { /** - * Create the {@link JdbcTemplate} to use in the {@link DbFacade} class. - * TODO: Remove this method once we don't use SqlServer anymore, since it's a needed only for SqlServer - * Compatibility. + * Create the {@link JdbcTemplate} to use in the {@link DbFacade} class. TODO: Remove this method once we don't use + * SqlServer anymore, since it's a needed only for SqlServer Compatibility. * - * @param dataSource The Data Source to use for the template. + * @param dataSource + * The Data Source to use for the template. * @return A {@link JdbcTemplate} that can be used to DB operations. */ public JdbcTemplate createJdbcTemplate(DataSource dataSource); /** * Create the object used for performing function calls for querying data and returning a result/list of results. - * This object can't be used safely to execute other commands, since it doesn't necessarily support features - * such as out parameters. However, it must be used in order to query the DB correctly using a function call. + * This object can't be used safely to execute other commands, since it doesn't necessarily support features such as + * out parameters. However, it must be used in order to query the DB correctly using a function call. * - * @param jdbcTemplate The JDBC template is needed for actually performing the calls. + * @param jdbcTemplate + * The JDBC template is needed for actually performing the calls. * @return A {@link SimpleJdbcCallOperations} instance that can be used to call a query function in the DB. */ public SimpleJdbcCallOperations createJdbcCallForQuery(JdbcTemplate jdbcTemplate); @@ -42,8 +43,9 @@ /** * TODO: Remove this method once we don't use SqlServer anymore, since it's a needed only for SqlServer * Compatibility. + * * @return The default key of the returned value by a function when called using - * {@link SimpleJdbcCallOperations#execute()}. + * {@link SimpleJdbcCallOperations#execute()}. */ public String getFunctionReturnKey(); } diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java index dc391dd..4a216f6 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java @@ -153,16 +153,16 @@ Map<String, Object> result = new HashMap<String, Object>(1); result.put(returnedMapKey, getJdbcTemplate().query( generateSql(), - new PreparedStatementSetter() { - @Override - public void setValues(PreparedStatement ps) throws SQLException { - List<SqlParameter> callParameters = getCallParameters(); - for (int i = 0; i < callParameters.size(); i++) { - SqlParameter parameter = callParameters.get(i); - ps.setObject(i + 1, params.get(parameter.getName()), parameter.getSqlType()); - } - } - }, rowMapper)); + new PreparedStatementSetter() { + @Override + public void setValues(PreparedStatement ps) throws SQLException { + List<SqlParameter> callParameters = getCallParameters(); + for (int i = 0; i < callParameters.size(); i++) { + SqlParameter parameter = callParameters.get(i); + ps.setObject(i + 1, params.get(parameter.getName()), parameter.getSqlType()); + } + } + }, rowMapper)); return result; } -- To view, visit http://gerrit.ovirt.org/15341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1719a0e300cba9bd5462685cde36a9dd3232a4e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
