Daniel Erez has posted comments on this change.
Change subject: webadmin: Added total size column to storage main tab
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
Line 100: long totalSpace = object.getTotalDiskSize() != null ?
object.getTotalDiskSize() : 0;
Line 101: return (long) totalSpace;
Line 102: }
Line 103: };
Line 104: getTable().addColumn(totalSpaceColumn,
constants.totalSpaceStorage(), "90px"); //$NON-NLS-1$
should be wider (truncated in some langs - e.g. Deutsch)
Line 105:
Line 106: DiskSizeColumn<StorageDomain> freeSpaceColumn = new
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
Line 107: @Override
Line 108: public Long getRawValue(StorageDomain object) {
Line 109: long availableDiskSize =
object.getAvailableDiskSize() != null ? object.getAvailableDiskSize() : 0;
Line 110: return (long) availableDiskSize;
Line 111: }
Line 112: };
Line 113: getTable().addColumn(freeSpaceColumn,
constants.freeSpaceStorage(), "90px"); //$NON-NLS-1$
same
Line 114:
Line 115: TextColumnWithTooltip<StorageDomain> descriptionColumn = new
TextColumnWithTooltip<StorageDomain>() {
Line 116: @Override
Line 117: public String getValue(StorageDomain object) {
--
To view, visit http://gerrit.ovirt.org/15336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10b9c68c01a88c91b9e17a4d2db74e8cd199c7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches