Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Unwritten public fields ......................................................................
findbugs: Unwritten public fields its mainly events or handlers that use by UI, assigned null instead of adding to ignore list findbugs reason: UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I8a8872dd0eb76ae0e4d92af54acec2807f6a1b64 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/15402/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java index 5e7eb7f..a961e57 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java @@ -65,7 +65,7 @@ } - public static ITagsHandler TagsHandler; + public static ITagsHandler TagsHandler = null; public Map<String, Class<?>> getTypeDictionary() { return typeDict; diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java index 8bdc323..dec0be5 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java @@ -16,7 +16,7 @@ public Object Model; public INewAsyncCallback asyncCallback; - public IAsyncConverter converterCallback; + public IAsyncConverter converterCallback = null; private boolean handleFailure; public VdcQueryReturnValue OriginalReturnValue; public Object[] Data; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java index 06a3241..7400cf7 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java @@ -46,7 +46,7 @@ protected SimplePanel actionPanelContainer; protected SubTabTreeActionPanel actionPanel; protected EntityModelCellTable<ListModel> table; - protected AbstractSubTabTree<M, R, N> tree; + protected AbstractSubTabTree<M, R, N> tree = null; protected final EventBus eventBus; protected SearchableDetailModelProvider<?, ?, M> modelProvider; -- To view, visit http://gerrit.ovirt.org/15402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a8872dd0eb76ae0e4d92af54acec2807f6a1b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
