Shahar Havivi has uploaded a new change for review. Change subject: findbugs: inaccurate floating point comparison ......................................................................
findbugs: inaccurate floating point comparison This operation compares two floating point values for equality. Because floating point calculations may involve rounding, calculated float and double values may not be accurate findbugs reason: FE: Test for floating point equality (FE_FLOATING_POINT_EQUALITY) Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/15413/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java index 391248b..b77efc9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java @@ -13,9 +13,9 @@ import org.ovirt.engine.core.common.businessentities.QuotaStorage; import org.ovirt.engine.core.common.businessentities.QuotaUsagePerUser; import org.ovirt.engine.core.common.businessentities.QuotaVdsGroup; +import org.ovirt.engine.core.common.businessentities.StoragePool; import org.ovirt.engine.core.common.businessentities.VM; import org.ovirt.engine.core.common.businessentities.VMStatus; -import org.ovirt.engine.core.common.businessentities.StoragePool; import org.ovirt.engine.core.common.config.Config; import org.ovirt.engine.core.common.config.ConfigValues; import org.ovirt.engine.core.common.errors.VdcBllMessages; @@ -985,7 +985,7 @@ if (QuotaStorage.UNLIMITED.equals(quotaStorage.getStorageSizeGB())) { storageLimit = QuotaStorage.UNLIMITED; // Do not break because usage is still counting } - if (storageLimit != QuotaStorage.UNLIMITED) { + if (!Double.valueOf(storageLimit).equals(QuotaStorage.UNLIMITED)) { storageLimit += quotaStorage.getStorageSizeGB(); } storageUsage += quotaStorage.getStorageSizeGBUsage(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java index e130cc2..5dbfc4f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java @@ -198,7 +198,7 @@ // checks if it is an enabled value for (double i = slider.getMinValue(); i <= newValue; i += slider.getStepSize()) { - if (i == newValue) { + if (Double.valueOf(i).equals(newValue)) { return true; } } -- To view, visit http://gerrit.ovirt.org/15413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
