Mei Liu has posted comments on this change.

Change subject: policy: Add 'require' keyword
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File mom/Policy/Parser.py
Line 362:         self.stack.leave_scope()
Line 363:         return result
Line 364: 
Line 365:     def c_require(self, kind, name, conf):
Line 366:         'value value code'
Could u remind me why do we need conf?
Line 367:         if not isinstance(conf, list):
Line 368:             raise PolicyError('Expecting list as arg 3 in require')
Line 369:         conf = map(lambda x: str(self.eval(x)), conf)
Line 370:         return 'require %s.%s %s' % (kind, name, ','.join(conf))


--
To view, visit http://gerrit.ovirt.org/13764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef20626301732ded6466a45000adcbc90f2aa20
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to