Mei Liu has posted comments on this change.

Change subject: Reconfigure MOM when a new policy is loaded
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

(1 inline comment)

I think the reconfig should also be called in policy engine for load_policy, 
otherwise the test http://gerrit.ovirt.org/#/c/15476/ will fail due to no 
collectors obtained from policy it self.

....................................................
File tests/GeneralTests.py
Line 180:             self.assertFalse('ksm_run' in stats['host'])
Line 181: 
Line 182:             self.assertTrue(mom_instance.setPolicy(pol2))
Line 183:             stats = wait_for_stats()
Line 184:             print stats['host']
Should print exist in test case?
Line 185:             self.assertFalse('mem_available' in stats['host'])


--
To view, visit http://gerrit.ovirt.org/13767
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8706d86bc5d615a06191dee4fbc6f58e37ee8c6
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to