Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added canDoAction checks in case of gluster host removal
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 89: // if host has bricks on a volume
Line 90: // if there is no up server in cluster, if host being
removed is not
Line 91: // last server in cluster
Line 92: if (hasVolumeBricksOnServer()) {
Line 93:
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_REMOVE_HOST_HAVING_GLUSTER_VOLUME);
why not using here failCanDoAction?
Have you considered reordering the code blocks for upServer == null and
upServer != null?
Line 94: returnValue = false;
Line 95: } else if (upServer == null &&
clusterHasMultipleHosts()) {
Line 96: addCanDoActionMessage(String.format("$clusterName
%1$s", getVdsGroup().getname()));
Line 97:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_UP_SERVER_FOUND);
--
To view, visit http://gerrit.ovirt.org/15401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42e1a5452e7c40ae770108cadaf69118b5e77719
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
