Yair Zaslavsky has posted comments on this change. Change subject: engine : Fix variable names in VdcReturnValueBase ......................................................................
Patch Set 14: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java Line 16: private boolean succeeded; Line 17: private boolean isSyncronious; Line 18: private Object returnValue; Line 19: private String description = ""; Line 20: private ArrayList<Guid> asyncTaskIdList = new ArrayList<Guid>(); Ravi, do we still need asyncTaskIdList? Maybe now that we we also store the task parameters it is not required? This will save confusion if we can remove it. Line 21: private ArrayList<Guid> vdsmTaskIdList = new ArrayList<Guid>(); Line 22: private final ArrayList<Guid> internalVdsmIdList = new ArrayList<Guid>(); Line 23: private boolean endActionTryAgain = true; Line 24: private final ArrayList<String> executeFailedMessages = new ArrayList<String>(); -- To view, visit http://gerrit.ovirt.org/14909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebfbd19f8eeef4a9a0d30eadaacb1d833cae0ec7 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
