Allon Mureinik has posted comments on this change.
Change subject: engine: add comment field to Cluster [2]
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_03_0180_add_comment_storage_pool.sql
Line 1: select fn_db_add_column('storage_pool', 'comment', 'text');
I guess this was added by mistake?
....................................................
File backend/manager/dbscripts/vds_groups_sp.sql
Line 9:
Line 10: Create or replace FUNCTION InsertVdsGroups(
Line 11: v_vds_group_id UUID,
Line 12: v_description VARCHAR(4000),
Line 13: v_comment text,
Not sure how postgres handles inline text variable, but I'd move this to the
end.
Line 14: v_name VARCHAR(40),
Line 15: v_cpu_name VARCHAR(255),
Line 16: v_selection_algorithm INTEGER,
Line 17: v_high_utilization INTEGER,
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 947:
Line 948: @DefaultStringValue("Description")
Line 949: String descriptionDc();
Line 950:
Line 951: // Storage DC
why are you removing commentDc()? I assume this is a git foobar?
Line 952: @DefaultStringValue("Domain Status in Data-Center")
Line 953: String domainStatusInDcStorageDc();
Line 954:
Line 955: @DefaultStringValue("Attach")
--
To view, visit http://gerrit.ovirt.org/15414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b203b757d6225ff1986aee47e8484e2838e795
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
