Alissa Bonas has posted comments on this change.

Change subject: core: add check for iqn in addStorageServerConn
......................................................................


Patch Set 3: Verified

(1 inline comment)

....................................................
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 2124: 
Line 2125:     @DefaultStringValue("Target details are empty.")
Line 2126:     String VALIDATION_STORAGE_CONNECTION_EMPTY_IQN_OR_CONN();
Line 2127: 
Line 2128:     @DefaultStringValue("Mount path is illegal, please use [IP:/path 
or FQDN:/path] convention.")
not related to the patch subject itself, however the error message was missing, 
so I added it "on the way".
Line 2129:     String VALIDATION_STORAGE_CONNECTION_INVALID();
Line 2130: 
Line 2131:     String VMPAYLOAD_INVALID_PAYLOAD_TYPE();
Line 2132: 


-- 
To view, visit http://gerrit.ovirt.org/15516
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to