Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Set Provider system tree icon by type
......................................................................

webadmin: Set Provider system tree icon by type

Added ability to set an icon for a Provider in the system tree specific
to the type of the provider, at the moment icon exists for OpenStack
Network.

Change-Id: I9f689bc4d9ab1227da8f1e763bf8149ec045a8ce
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
A 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_openstack.png
D 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_provider.png
M 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png
A 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_openstack.png
A 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_providers.png
8 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/15526/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
index 39628f0..31e8d36 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
@@ -589,6 +589,7 @@
             providerItem.setTitle(provider.getName());
             providerItem.setParent(providersItem);
             providersItem.getChildren().add(providerItem);
+            providerItem.setEntity(provider);
             treeItemById.put(provider.getId(), providerItem);
         }
 
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
index 972d20e..bfeec46 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
@@ -122,6 +122,9 @@
     @Source("images/nonoperational.png")
     ImageResource nonOperationalImage();
 
+    @Source("images/icon_openstack.png")
+    ImageResource openstackImage();
+
     @Source("images/pause.gif")
     ImageResource pauseImage();
 
@@ -139,9 +142,6 @@
 
     @Source("images/plus.png")
     ImageResource plusImage();
-
-    @Source("images/icon_provider.png")
-    ImageResource providerImage();
 
     @Source("images/icon_providers.png")
     ImageResource providersImage();
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
index 4f3a707..92d0905 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
@@ -1,5 +1,6 @@
 package org.ovirt.engine.ui.webadmin.widget.tree;
 
+import org.ovirt.engine.core.common.businessentities.Provider;
 import org.ovirt.engine.ui.common.utils.ElementIdUtils;
 import org.ovirt.engine.ui.uicommonweb.models.SystemTreeItemModel;
 import org.ovirt.engine.ui.webadmin.ApplicationResources;
@@ -80,7 +81,13 @@
             imageResource = applicationResources.networksTreeImage();
             break;
         case Provider:
-            imageResource = applicationResources.providerImage();
+            switch (((Provider) value.getEntity()).getType()) {
+            case OPENSTACK_NETWORK:
+                imageResource = applicationResources.openstackImage();
+                break;
+            default:
+                imageResource = applicationResources.providersImage();
+            }
             break;
         case Providers:
             imageResource = applicationResources.providersImage();
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_openstack.png
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_openstack.png
new file mode 100644
index 0000000..4fcdaeb
--- /dev/null
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_openstack.png
Binary files differ
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_provider.png
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_provider.png
deleted file mode 100644
index 932d417..0000000
--- 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_provider.png
+++ /dev/null
Binary files differ
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png
index 86a8239..e066ce7 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icon_providers.png
Binary files differ
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_openstack.png
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_openstack.png
new file mode 100644
index 0000000..4fcdaeb
--- /dev/null
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_openstack.png
Binary files differ
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_providers.png
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_providers.png
new file mode 100644
index 0000000..e066ce7
--- /dev/null
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/icon_providers.png
Binary files differ


-- 
To view, visit http://gerrit.ovirt.org/15526
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f689bc4d9ab1227da8f1e763bf8149ec045a8ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to