Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: service: preserve log handler ......................................................................
packaging: service: preserve log handler daemon closes all handles, doing that for handlers will issue a warning when handler tries to write to the opened python object. oddly, everything continue to work... Change-Id: I027c4caba21a6712bb1c89c29d17ef4e02c56130 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/services/service.py 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/15534/1 diff --git a/packaging/services/service.py b/packaging/services/service.py index a621d9c..9703b20 100755 --- a/packaging/services/service.py +++ b/packaging/services/service.py @@ -496,6 +496,15 @@ def _myterm(signum, frame): raise self.TerminateException() + # + # preserve log handler. + # bit undocumented. + # + handles = [] + for l in logging.getLogger('ovirt').handlers: + if hasattr(l, 'socket'): + handles.append(l.socket) + with daemon.DaemonContext( detach_process=self._options.background, signal_map={ @@ -505,6 +514,7 @@ }, stdout=stdout, stderr=stderr, + files_preserve=handles, umask=0o022, ): self._logger.debug('I am a daemon %s', os.getpid()) -- To view, visit http://gerrit.ovirt.org/15534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I027c4caba21a6712bb1c89c29d17ef4e02c56130 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
