Ravi Nori has posted comments on this change.
Change subject: core: Propagate ldap query error properly to UI
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor usage comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
Line 74: getClass().getSimpleName(), getDomain(),
getLoginName()));
Line 75: }
Line 76: finally {
Line 77: if (exceptionOccured) {
Line 78:
_ldapReturnValue.setExceptionString(VdcBllMessages.FAILED_TO_RUN_LDAP_QUERY.name());
Is there a reason we are using .name() instead of toString()
http://stackoverflow.com/questions/13291076/java-enum-why-use-tostring-instead-of-name
Just curious
Line 79: _ldapReturnValue.setSucceeded(false);
Line 80: }
Line 81: }
Line 82: return _ldapReturnValue;
--
To view, visit http://gerrit.ovirt.org/15556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If06e251ec31f208dd0e25084d5aaa37625d299cc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
