Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix disk allocation on new VM/Template
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
Line 58: private void registerToEvents() {
Line 59: for (final DiskModel diskModel : disks) {
Line 60:
diskModel.getStorageDomain().getSelectedItemChangedEvent().removeListener(quota_storageEventListener);
Line 61:
diskModel.getStorageDomain().getSelectedItemChangedEvent().addListener(quota_storageEventListener);
Line 62:
diskModel.getStorageDomain().getItemsChangedEvent().addListener(new
IEventListener() {
registerToEvents may be called more than once - it would probably be better to
verify the listener is added only once (similar to quota_storageEventListener
handling)
Line 63: @Override
Line 64: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 65: DiskImage disk = (DiskImage) diskModel.getDisk();
Line 66: if (diskModel.getStorageDomain().getItems() !=
null && disk.getStorageIds() != null
--
To view, visit http://gerrit.ovirt.org/15576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2f71c4f18ccb52362272edf56853e2fde9643f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
