Michael Pasternak has posted comments on this change.
Change subject: restapi : call to show files on iso domain no longer shows all
files
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java
Line 71: }
Line 72: }
Line 73:
Line 74: protected List<String> listFiles() {
Line 75: GetImagesListParameters queryParams = new
GetImagesListParameters(asGuid(storageDomainId), ImageFileType.All);
the test for list() is not correct, please fix it.
Line 76: queryParams.setForceRefresh(true);
Line 77:
Line 78: List<RepoFileMetaData> files =
getBackendCollection(RepoFileMetaData.class, VdcQueryType.GetImagesList,
Line 79: queryParams);
--
To view, visit http://gerrit.ovirt.org/13730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31d305baaa28e5c0f0b918e497197dbd7b0e496e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches