Juan Hernandez has uploaded a new change for review. Change subject: core: Remove unused ctors from Ad*SearchParameters ......................................................................
core: Remove unused ctors from Ad*SearchParameters The AdUser and AdGroup search parameters classes have two constructors, the second one receiving a flag to indicate if the search should be case sensitive or not. These constructors are only used in the corresponding test classes. This change removes those constructors and their tests. Change-Id: I72b89aabdea2d9a6a45f8613ec196ce8bcf0cf95 Signed-off-by: Juan Hernandez <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java 4 files changed, 0 insertions(+), 48 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/15642/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java index 6a8910c..a56cdb5 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java @@ -14,10 +14,6 @@ super(searchPattern, SearchType.AdGroup); } - public AdGroupsSearchParameters(String searchPattern, boolean caseSensitive) { - super(searchPattern, SearchType.AdGroup, caseSensitive); - } - /** Prepends "AdGroups:" to the given search string */ @Override public String getSearchPattern() { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java index c397de1..cf4f771 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java @@ -14,10 +14,6 @@ super(searchPattern, SearchType.AdUser); } - public AdUsersSearchParameters(String searchPattern, boolean caseSensitive) { - super(searchPattern, SearchType.AdUser, caseSensitive); - } - /** Prepends "AdUsers:" to the given search string */ @Override public String getSearchPattern() { diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java index 598a9d5..b3896b3 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java @@ -3,21 +3,11 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -import java.util.Random; - -import org.junit.Before; import org.junit.Test; import org.ovirt.engine.core.common.interfaces.SearchType; /** A test case for the {@link AdGroupsSearchParameters} class */ public class AdGroupsSearchParametersTest { - - private Random random; - - @Before - public void setUp() { - this.random = new Random(); - } @Test public void testOneArgConstructor() { @@ -28,14 +18,4 @@ assertEquals("Wrong type", SearchType.AdGroup, params.getSearchTypeValue()); } - @Test - public void testTwoArgConstructor() { - String pattern = "pattern"; - boolean caseSensitive = this.random.nextBoolean(); - AdGroupsSearchParameters params = new AdGroupsSearchParameters(pattern, caseSensitive); - - assertTrue("Wrong pattern", params.getSearchPattern().endsWith(pattern)); - assertEquals("Wrong type", SearchType.AdGroup, params.getSearchTypeValue()); - assertEquals("Wrong case sensitivity", caseSensitive, params.getCaseSensitive()); - } } diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java index a24aff3..517e00f 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java @@ -3,21 +3,11 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -import java.util.Random; - -import org.junit.Before; import org.junit.Test; import org.ovirt.engine.core.common.interfaces.SearchType; /** A test case for the {@link AdUsersSearchParameters} class */ public class AdUsersSearchParametersTest { - - private Random random; - - @Before - public void setUp() { - this.random = new Random(); - } @Test public void testOneArgConstructor() { @@ -28,14 +18,4 @@ assertEquals("Wrong type", SearchType.AdUser, params.getSearchTypeValue()); } - @Test - public void testTwoArgConstructor() { - String pattern = "pattern"; - boolean caseSensitive = this.random.nextBoolean(); - AdUsersSearchParameters params = new AdUsersSearchParameters(pattern, caseSensitive); - - assertTrue("Wrong pattern", params.getSearchPattern().endsWith(pattern)); - assertEquals("Wrong type", SearchType.AdUser, params.getSearchTypeValue()); - assertEquals("Wrong case sensitivity", caseSensitive, params.getCaseSensitive()); - } } -- To view, visit http://gerrit.ovirt.org/15642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72b89aabdea2d9a6a45f8613ec196ce8bcf0cf95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
