Allon Mureinik has posted comments on this change.
Change subject: engine: add comment field to Storage [5]
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
Line 44: // Collect changed fields to update in a list.
Line 45: List<String> props =
ObjectIdentityChecker.GetChangedFields(oldDomain, getStorageDomain()
Line 46: .getStorageStaticData());
Line 47:
Line 48: // Allow change only to name & description field
please fix the comment accordingly
Line 49: props.remove("storageName");
Line 50: props.remove("description");
Line 51: props.remove("comment");
Line 52: if (returnValue && props.size() > 0) {
--
To view, visit http://gerrit.ovirt.org/15486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fd8a1b83ed330c945025f13abf565fd899563e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
