Allon Mureinik has posted comments on this change.

Change subject: engine: add comment field to VM,Template,Pool [6]
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File backend/manager/dbscripts/upgrade/03_03_0250_add_comment_storage_pool.sql
Line 1: select fn_db_add_column('storage_pool', 'comment', 'text');
This has nothing to do with the patch - please remove


....................................................
File backend/manager/dbscripts/upgrade/03_03_0260_add_comment_vds_groups.sql
Line 1: select fn_db_add_column('vds_groups', 'comment', 'text');
why is this related to the patch?


-- 
To view, visit http://gerrit.ovirt.org/15643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8c0af979e9ec4724284d92f79a0b688e961425
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to