Michael Pasternak has posted comments on this change. Change subject: engine: add comment field to DataCenter [1] ......................................................................
Patch Set 9: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 979: minOccurs="0" /> Line 980: <xs:element name="version" type="Version" minOccurs="0" /> Line 981: <xs:element name="supported_versions" Line 982: type="SupportedVersions" minOccurs="0" /> Line 983: <xs:element ref="status" minOccurs="0" maxOccurs="1" /> please revert formatting Line 984: <!-- also rel="files" and rel="storagedomains" links --> Line 985: <xs:element name="comment" type="xs:string" minOccurs="0" maxOccurs="1"></xs:element> Line 986: </xs:sequence> Line 987: </xs:extension> Line 981: <xs:element name="supported_versions" Line 982: type="SupportedVersions" minOccurs="0" /> Line 983: <xs:element ref="status" minOccurs="0" maxOccurs="1" /> Line 984: <!-- also rel="files" and rel="storagedomains" links --> Line 985: <xs:element name="comment" type="xs:string" minOccurs="0" maxOccurs="1"></xs:element> 1. please move this property to the "BaseResource" (so it will be reusable by others) 2. please document it in the datacenter.add()/update() signatures at rsdl_metadata.yaml 3. please test it in the DataCenterMapperTest Line 986: </xs:sequence> Line 987: </xs:extension> Line 988: </xs:complexContent> Line 989: </xs:complexType> .................................................... Commit Message Line 5: CommitDate: 2013-06-10 18:04:39 +0300 Line 6: Line 7: engine: add comment field to DataCenter [1] Line 8: Line 9: As part of the Free Text RFE any reason we can't use 'description' for that? Line 10: Line 11: Added to the entities flow in the system Line 12: DB <-> DAO <-> Entity <-> Model <-> UI Line 13: DB <-> DAO <-> Entity <-> REST -- To view, visit http://gerrit.ovirt.org/14878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
