Alissa Bonas has posted comments on this change.
Change subject: core: Cleanup Guid(bytep[], boolean)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
Line 33: this.uuid = uuid;
Line 34: }
Line 35:
Line 36: public Guid(byte[] guid, boolean keepByteOrder) {
Line 37: String guidAsStr = getStrRepresentationOfGuid(guid,
keepByteOrder);
isn't it a bit strange to get a byte array, convert it to string and then
convert it to uuid? Why the conversion is not straight from byte arr to guid?
Historical reasons or technical restriction?
Line 38: uuid = UUID.fromString(guidAsStr);
Line 39: }
Line 40:
Line 41: public Guid(String candidate) {
--
To view, visit http://gerrit.ovirt.org/15754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e992946f4c73c7e7f5d89a691a0b841d38c888b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
