Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added "new network" popup on Providers tab
......................................................................
Patch Set 16: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderNetworkListModel.java
Line 161:
Line 162: cancel();
Line 163: }
Line 164:
Line 165: public void add() {
This code should reside in ProviderNewNetworkModel. Was it fixed in a further
patch?
Line 166: if (getWindow() != null) {
Line 167: return;
Line 168: }
Line 169:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
Line 264: @Override
Line 265: public void updateVisibility() {
Line 266: messageLabel.setVisible(false);
Line 267: publicUseEditor.setVisible(false);
Line 268: networkLabelEditor.setVisible(false);
Why here and not in the model?
Line 269: }
Line 270:
Line 271: interface WidgetStyle extends CssResource {
Line 272: String mtuEditor();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderNewNetworkPopupView.java
Line 20:
Line 21: @Override
Line 22: public void updateVisibility() {
Line 23: super.updateVisibility();
Line 24: networkLabelEditor.setVisible(true);
Why here and not in the model?
Line 25: }
Line 26:
--
To view, visit http://gerrit.ovirt.org/11409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1db12f4803bcf9456a7a2df0d9b198ab862cb93
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
