Allon Mureinik has posted comments on this change.
Change subject: core: add validation non empty connection field
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Giving +1, let's give Cheryn a chance to comment on AppErrors
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 384: TransactionSupport.executeInScope(scope, code);
Line 385: }
Line 386:
Line 387: protected boolean
checkIsConnectionFieldEmpty(StorageServerConnections connection) {
Line 388: if (StringUtils.isEmpty(connection.getconnection())) {
Fix the indentation please
Line 389: String fieldName = getFieldName(connection);
Line 390: addCanDoActionMessage(String.format("$fieldName %1$s",
fieldName));
Line 391:
addCanDoActionMessage(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION);
Line 392: return true;
--
To view, visit http://gerrit.ovirt.org/15560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
