Itamar Heim has posted comments on this change.
Change subject: core: expand VDS monitoring with cluster emulation modes
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
Line 49:
Line 50: private boolean hostEmulationModeMatchesTheConfigValues(VDS vds,
String[] hostSupportedEmulatedMachines) {
Line 51: // match this host against the config flags by order
Line 52: String matchedEmulatedMachine = ListUtils.firstMatch(
Line 53:
Arrays.asList(Config.<String>GetValue(ConfigValues.ClusterEmulatedMachines).split(",")),
this config is cluster-compat version aware - please review all places you are
using it in the patch series.
Line 54: hostSupportedEmulatedMachines);
Line 55:
Line 56: if (matchedEmulatedMachine != null &&
!matchedEmulatedMachine.isEmpty()) {
Line 57: setClusterEmulatedMachine(vds, matchedEmulatedMachine);
--
To view, visit http://gerrit.ovirt.org/15868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0caf343d4d883a1e420ca2b4fc24c678436599cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
