Omer Frenkel has posted comments on this change.
Change subject: core: Add supportedEmulatedMachines to Host model cluster
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 30:
Line 31: /**
Line 32: * comma separated list of emulated machines the host supports
Line 33: */
Line 34: private String supportedEmulatedMachines;
why this is here? get/set are using the vdsDynamic obj
Line 35:
Line 36: public VDS() {
Line 37: mVdsStatic = new VdsStatic();
Line 38: mVdsDynamic = new VdsDynamic();
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 512: <column>virt_service</column>
Line 513: <column>gluster_service</column>
Line 514: <column>count_threads_as_cores</column>
Line 515: <column>tunnel_migration</column>
Line 516: <column>emulated_machine</column>
since this field can be null i think its a good idea to have at least one
instance here with null to make sure this case is tested as well
Line 517: <row>
Line 518: <value>b399944a-81ab-4ec5-8266-e19ba7c3c9d1</value>
Line 519: <value>rhel6.iscsi</value>
Line 520: <null />
Line 528: <value>6d849ebf-755f-4552-ad09-9a090cda105d</value>
Line 529: <value>200</value>
Line 530: <value>2.3</value>
Line 531: <value>0</value>
Line 532: <value>t/rue</value>
what and why?
Line 533: <value>false</value>
Line 534: <value>false</value>
Line 535: <value>false</value>
Line 536: <value>pc-1.0</value>
Line 1749: <column>hw_version</column>
Line 1750: <column>hw_serial_number</column>
Line 1751: <column>hw_uuid</column>
Line 1752: <column>hw_family</column>
Line 1753: <column>supported_emulated_machines</column>
since this field can be null i think its a good idea to have at least one
instance here with null to make sure this case is tested as well
Line 1754: <row>
Line 1755: <value>afce7a39-8e8c-4819-ba9c-796d316592e6</value>
Line 1756: <value>3</value>
Line 1757: <value>8</value>
--
To view, visit http://gerrit.ovirt.org/15864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25df8376026f3e5f57ce85d8e7a20e5000ce7eed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
