Itamar Heim has posted comments on this change.
Change subject: core: add clusterEmulatedMachines config values
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 68: select fn_db_add_config_value('CipherSuite','DEFAULT','general');
Line 69: --Handling Configuration directory for ENGINE
Line 70: select fn_db_add_config_value('ConfigDir','/etc/engine','general');
Line 71: select
fn_db_add_config_value('ConnectToServerTimeoutInSeconds','20','general');
Line 72: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.2.0,
pc-1.0','general');
why do we need a default value and not only per cluster version?
Line 73: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.2.0,
pc-1.0','3.0');
Line 74: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.3.0,
pc-1.0','3.1');
Line 75: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,
pc-1.0','3.2');
Line 76: select fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,
pc-1.0','3.3');
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1378: @DefaultValueAttribute("/osinfo.conf.d")
Line 1379: OsRepositoryConfDir(512),
Line 1380:
Line 1381: @TypeConverterAttribute(java.util.List.class)
Line 1382: @DefaultValueAttribute("rhel5.5.0,pc-1.0")
rhel-5.5 is just no longer relevant?
Line 1383: ClusterEmulatedMachines(513),
Line 1384:
Line 1385: Invalid(65535);
Line 1386:
--
To view, visit http://gerrit.ovirt.org/15865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c820d928e2b8c891c99b0980e81d8aefb5abfed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
