Arik Hadas has uploaded a new change for review. Change subject: core: organize VDSReturnValue class ......................................................................
core: organize VDSReturnValue class 1. Move all fields declarations up to beginning of the class 2. Remove the '_' prefix from the fields names 3. Move the constructor to be right after the fields declarations Change-Id: I7a5ceaa2271dc934577a55f7de596cbcef7e25cd Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java 1 file changed, 18 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/15875/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java index fa6a582..3c83cdf 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java @@ -4,44 +4,48 @@ import org.ovirt.engine.core.common.errors.VDSError; public class VDSReturnValue { - private boolean _succeeded; - private String _exceptionString; - private Object _returnValue; - private RuntimeException _exceptionObject; + + private boolean succeeded; + private String exceptionString; + private Object returnValue; + private RuntimeException exceptionObject; + private AsyncTaskCreationInfo privateCreationInfo; + private VDSError privateVdsError; + + public VDSReturnValue() { + } public Object getReturnValue() { - return _returnValue; + return returnValue; } public void setReturnValue(Object value) { - _returnValue = value; + returnValue = value; } public String getExceptionString() { - return _exceptionString; + return exceptionString; } public void setExceptionString(String value) { - _exceptionString = value; + exceptionString = value; } public boolean isSucceeded() { - return _succeeded; + return succeeded; } public void setSucceeded(boolean value) { - _succeeded = value; + succeeded = value; } public RuntimeException getExceptionObject() { - return _exceptionObject; + return exceptionObject; } public void setExceptionObject(RuntimeException value) { - _exceptionObject = value; + exceptionObject = value; } - - private AsyncTaskCreationInfo privateCreationInfo; public AsyncTaskCreationInfo getCreationInfo() { return privateCreationInfo; @@ -51,16 +55,11 @@ privateCreationInfo = value; } - private VDSError privateVdsError; - public VDSError getVdsError() { return privateVdsError; } public void setVdsError(VDSError value) { privateVdsError = value; - } - - public VDSReturnValue() { } } -- To view, visit http://gerrit.ovirt.org/15875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a5ceaa2271dc934577a55f7de596cbcef7e25cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
