Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Build and install ovirt guest agent on Ubuntu
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File Makefile.am
Line 58: $(MKDIR_P) $(DESTDIR)/$(pkgdatadir)
Line 59: $(LN_S) -f $(bindir)/consolehelper
$(DESTDIR)/$(pkgdatadir)/ovirt-locksession
Line 60: $(LN_S) -f $(bindir)/consolehelper
$(DESTDIR)/$(pkgdatadir)/ovirt-shutdown
Line 61: $(LN_S) -f $(bindir)/consolehelper
$(DESTDIR)/$(pkgdatadir)/ovirt-hibernate
Line 62: $(INSTALL) -d $(DESTDIR)/$(localstatedir)/lock/ovirt-guest-agent
I decided to detect /var/lock/subsys and /var/lock if the first is there, it
will use the first, otherwise the latter
....................................................
File ovirt-guest-agent/ovirt-guest-agent
Line 12: . /etc/rc.d/init.d/functions
Line 13:
Line 14: agentd=/usr/share/ovirt-guest-agent/ovirt-guest-agent.py
Line 15: prog=ovirt-guest-agent
Line 16: lockfile=/var/lock/${prog}
this is now implemented within autoconf
Line 17: pidfile=/var/run/${prog}.pid
Line 18:
Line 19: RETVAL=0
Line 20:
....................................................
File ubuntuInstall.sh
Line 1: #!/bin/bash
Line 2:
Line 3: echo "Dependencies: make gcc libtool autoconf libpam-dev pep8 usermode
python-ethtool python-dev python-dbus"
Line 4: echo "Please resolve the dependencies manually by apt-get install them,
then run this script to build and install ovirt guest agent."
We'll put that in there once we're having the debian package
This is just a convenience script until we have it in place. It's taken from
your github repo anyway ;)
Line 5: echo "[Press ENTER to continue]"
Line 6: read
Line 7:
Line 8: [ -e Makefile ] && make clean
Line 16:
Line 17: sudo stop ovirt-guest-agent >/dev/null 2>&1
Line 18:
Line 19: sudo make install
Line 20:
Good point, we'll put into Makefile.am what's feasible. I guess there needs to
be some conditions since we don't have all the same things on all systems to
do. e.g. adduser ovirtagent netdev is ubuntu (maybe even debian) specific.
So we'll have to provide conditions on that, however that should be doable.
Line 21: getent group ovirtagent >/dev/null || sudo groupadd -r -g 175
ovirtagent
Line 22: getent passwd ovirtagent > /dev/null || \
Line 23: sudo /usr/sbin/useradd -u 175 -g 175 -o -r ovirtagent \
Line 24: -c "oVirt Guest Agent" -d /usr/share/ovirt-guest-agent -s
/sbin/nologin
--
To view, visit http://gerrit.ovirt.org/15313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a694bf1f7ff4230bac305dd571899265ef63950
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
