Yedidyah Bar David has posted comments on this change.
Change subject: Log setup events
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File Makefile
Line 173: packaging/services/ovirt-engine-notifier.sysv \
Line 174: packaging/services/ovirt-websocket-proxy.systemd \
Line 175: packaging/services/ovirt-websocket-proxy.sysv \
Line 176: packaging/setup/ovirt_engine_setup/config.py \
Line 177: packaging/fedora/setup/ovirt-engine-log-setup-event.sh \
Done
Line 178: ovirt-engine.spec \
Line 179: $(NULL)
Line 180:
Line 181: all: \
....................................................
File packaging/fedora/setup/ovirt-engine-log-setup-event.sh.in
Line 47: --notes=*)
Line 48: notes="${v}"
Line 49: ;;
Line 50: --help)
Line 51: usage
I copied this from some other script in ovirt, not sure which.
A quick google search finds:
http://www.gnu.org/prep/standards/html_node/_002d_002dhelp.html
Done.
Line 52: ;;
Line 53: *)
Line 54: die "Invalid option '${x}'"
Line 55: ;;
Line 59: (
Line 60: echo SETUP-EVENT-BEGIN
Line 61: echo DATE: $(date +'%Y-%m-%d %H:%M:%S')
Line 62: echo NOTES: ${notes}
Line 63: rpm -qa | sort | while read package; do
OK. Also filtered to list only some packages - please either tell me if you'd
rather not filter or what to add to it. Thanks.
Line 64: echo PACKAGE: ${package}
Line 65: done
Line 66: echo SETUP-EVENT-END
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
