Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: update httpd conf during upgrade
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 344: 
Line 345:     HTTPD_CONF_OVIRT_ENGINE_LEGACY = os.path.join(
Line 346:         DIR_HTTPD,
Line 347:         'conf.d',
Line 348:         'ovirt-engine.conf'
Done
Line 349:     )
Line 350: 
Line 351:     AIO_VDSM_PATH = os.path.join(
Line 352:         DATADIR,


....................................................
File packaging/setup/plugins/ovirt-engine-setup/apache/ovirt_engine.py
Line 100:         ],
Line 101:         condition=lambda self: (
Line 102:             os.path.exists(
Line 103:                 
osetupcons.FileLocations.HTTPD_CONF_OVIRT_ENGINE_LEGACY
Line 104:             ) and not 
self.environment[osetupcons.CoreEnv.DEVELOPER_MODE]
moved to a separate plugin so we can delete it as-is in future.
Line 105:         ),
Line 106:     )
Line 107:     def _closeup(self):
Line 108:         self.environment[osetupcons.ApacheEnv.NEED_RESTART] = True


-- 
To view, visit http://gerrit.ovirt.org/15881
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b82fed02d643497ac86c0f52a887bdea22fabc3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to