Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Fix postMessage listener for IE9 ......................................................................
webadmin: Fix postMessage listener for IE9 Simplified postMessage listener registration and verified that it works for IE9 too. Change-Id: I4298d84d0f8fcfb8ac7315a881aaba6fa2c22654 Signed-off-by: Vojtech Szocs <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/15888/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java index f2a424c..2660b44 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java @@ -31,15 +31,17 @@ private native void registerMessageEventListener() /*-{ var context = this; - // Browsers compliant with postMessage API: window.addEventListener('message', callback, false) - // IE versions prior to IE9: window.attachEvent('onmessage', callback) - var eventListenerMethod = $wnd.addEventListener ? 'addEventListener' : 'attachEvent'; - var eventerFunction = $wnd[eventListenerMethod]; - var messageEventType = (eventListenerMethod == 'attachEvent') ? 'onmessage' : 'message'; - - eventerFunction(messageEventType, function(event) { + var callback = function(event) { conte...@org.ovirt.engine.ui.webadmin.system.PostMessageDispatcher::onMessage(Ljava/lang/String;Ljava/lang/Object;Lcom/google/gwt/core/client/JavaScriptObject;)(event.origin,event.data,event.source); - }, false); + }; + + if ($wnd.addEventListener) { + // Modern web browsers, including IE9+ + $wnd.addEventListener('message', callback, false); + } else { + // IE8 + $wnd.attachEvent('onmessage', callback); + } }-*/; } -- To view, visit http://gerrit.ovirt.org/15888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4298d84d0f8fcfb8ac7315a881aaba6fa2c22654 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
