Ravi Nori has posted comments on this change.
Change subject: 6. core: Persist all async task placeholders
......................................................................
Patch Set 16: (3 inline comments)
Did not handle Omer's idea
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 143: public void addChildCommandInfo(Guid id, VdcActionType
vdcActionType, VdcActionParametersBase parameters) {
Line 144: childCommandInfoMap.put(id, new Pair<VdcActionType,
VdcActionParametersBase>(vdcActionType, parameters));
Line 145: }
Line 146:
Line 147: protected List<VdcReturnValueBase> executeChildCommands() {
fixed
Line 148: List<VdcReturnValueBase> results = new ArrayList<>();
Line 149: for (CommandBase<?> command : childCommandsMap.values()) {
Line 150:
results.add(getBackendCommandObjectsHandler().runAction(command,
getExecutionContext()));
Line 151: }
Line 144: childCommandInfoMap.put(id, new Pair<VdcActionType,
VdcActionParametersBase>(vdcActionType, parameters));
Line 145: }
Line 146:
Line 147: protected List<VdcReturnValueBase> executeChildCommands() {
Line 148: List<VdcReturnValueBase> results = new ArrayList<>();
fixed
Line 149: for (CommandBase<?> command : childCommandsMap.values()) {
Line 150:
results.add(getBackendCommandObjectsHandler().runAction(command,
getExecutionContext()));
Line 151: }
Line 152: return results;
Line 1262: return annotation != null && annotation.forceCompensation();
Line 1263: }
Line 1264:
Line 1265: /**
Line 1266: * This method is called before executeAction and after
checkCanDoAction
fixed
Line 1267: * to insert the async task place holders for the child commands.
Line 1268: */
Line 1269: protected void insertAsyncTaskPlaceHolders() {
Line 1270:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
