Michael Pasternak has posted comments on this change.
Change subject: engine: watchdog - restapi support
......................................................................
Patch Set 33: I would prefer that you didn't submit this
(2 inline comments)
well done lazlo, you almost done:
1. couple of tiny comments inline
2. please add tests to all *Watchdog collection/resource resources you've added.
3. document watchdog collection/resource/operations in the rsdl_metadata.yaml
thanks
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
Line 128: protected Template doPopulate(Template model, VmTemplate entity) {
Line 129: return model;
Line 130: }
Line 131:
Line 132: @Path("watchdogs")
no path definitions should take place in the implementation classes, it should
be in interface
Line 133: @Override
Line 134: public WatchdogsResource getWatchdogsResource() {
Line 135: return inject(new BackendWatchdogsResource(guid,
Line 136: VdcQueryType.GetWatchdog,
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java
Line 112: vmWatchdog.setId(new Guid(device.getId()));
Line 113: return vmWatchdog;
Line 114: }
Line 115: });
Line 116: }*/
please remove this ^
Line 117:
Line 118: @Override
Line 119: protected <T> boolean matchEntity(VmWatchdog entity, T id) {
Line 120: //since there can be only one
--
To view, visit http://gerrit.ovirt.org/13060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5b20ecf2221faf900cadfeafe4c71607a9eca3
Gerrit-PatchSet: 33
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
