Sandro Bonazzola has posted comments on this change. Change subject: packaging: Added backup DB functionality to setup ......................................................................
Patch Set 7: (1 inline comment) .................................................... File packaging/common_utils.py Line 732: '--format=p', Line 733: '-U', db_dict['username'], Line 734: '-h', db_dict['host'], Line 735: '-p', db_dict['port'], Line 736: '-Fc', But since -Fc is compatible with pg_restore it should be ok. Line 737: '-f', backup_file, Line 738: db_dict['name'], Line 739: ] Line 740: execCmd( -- To view, visit http://gerrit.ovirt.org/15772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccf8938099207b4e73bb947d1bb5fd673605071 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches