Daniel Erez has uploaded a new change for review.

Change subject: webadmin: removing In-Use column from LUNs tables
......................................................................

webadmin: removing In-Use column from LUNs tables

Removing 'In Use' column from LUNs tables since its
meaning is confusing (relates only to the underline
LUN status).

Change-Id: I403079842e2ad44e925239cd0a1a2a93c4392b05
Signed-off-by: Daniel Erez <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
3 files changed, 0 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/15946/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
index f3669d7..052777f 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
@@ -1033,9 +1033,6 @@
     @DefaultStringValue("Format")
     String formatSanImStorage();
 
-    @DefaultStringValue("In Use")
-    String statusSanStorage();
-
     @DefaultStringValue("N/A")
     String notAvailableLabel();
 
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
index be40fb4..9f3ebe1 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
@@ -11,7 +11,6 @@
 import org.ovirt.engine.ui.uicommonweb.models.storage.LunModel;
 import org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModelBase;
 import org.ovirt.engine.ui.uicommonweb.models.storage.SanTargetModel;
-import org.ovirt.engine.ui.uicompat.EnumTranslator;
 import org.ovirt.engine.ui.uicompat.Event;
 import org.ovirt.engine.ui.uicompat.EventArgs;
 import org.ovirt.engine.ui.uicompat.IEventListener;
@@ -222,13 +221,6 @@
                 return String.valueOf(model.getMultipathing());
             }
         }, constants.pathSanStorage(), "55px"); //$NON-NLS-1$
-
-        table.addColumn(new LunTextColumn() {
-            @Override
-            public String getRawValue(LunModel model) {
-                return EnumTranslator.createAndTranslate(model.getStatus());
-            }
-        }, constants.statusSanStorage(), "75px"); //$NON-NLS-1$
 
         table.addColumn(new LunTextColumn() {
             @Override
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
index 9d65f1b..ad1021d 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
@@ -14,7 +14,6 @@
 import org.ovirt.engine.ui.uicommonweb.models.storage.LunModel;
 import org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModelBase;
 import org.ovirt.engine.ui.uicommonweb.models.storage.SanTargetModel;
-import org.ovirt.engine.ui.uicompat.EnumTranslator;
 
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.Scheduler;
@@ -217,13 +216,6 @@
                 return String.valueOf(model.getMultipathing());
             }
         }, constants.pathSanStorage(), "55px"); //$NON-NLS-1$
-
-        table.addColumn(new LunTextColumn() {
-            @Override
-            public String getRawValue(LunModel model) {
-                return EnumTranslator.createAndTranslate(model.getStatus());
-            }
-        }, constants.statusSanStorage(), "75px"); //$NON-NLS-1$
 
         table.addColumn(new LunTextColumn() {
             @Override


-- 
To view, visit http://gerrit.ovirt.org/15946
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I403079842e2ad44e925239cd0a1a2a93c4392b05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to