Gilad Chaplik has posted comments on this change. Change subject: webadmin: refactored host/cluster general tab mode checks ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java Line 131: Line 132: // Build a form using the FormBuilder Line 133: formBuilder = new FormBuilder(formPanel, 3, 7); Line 134: Line 135: formBuilder.addFormItem(new FormItem(constants.osVersionHostGeneral(), oS, 0, 0)); It looks like that both addFormItem and setIsAvailable invoke AbstractFormPanel.updateFormItem(). maybe it's better to pass visibly in the ctor. Line 136: formBuilder.addFormItem(new FormItem(constants.kernelVersionHostGeneral(), kernelVersion, 1, 0)); Line 137: formBuilder.addFormItem(new FormItem(constants.kvmVersionHostGeneral(), kvmVersion, 2, 0)) Line 138: .setIsAvailable(virtSupported); Line 139: formBuilder.addFormItem(new FormItem(constants.libvirtVersionHostGeneral(), libvirtVersion, 3, 0)) -- To view, visit http://gerrit.ovirt.org/15947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
