Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added postinstall file creation ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 535: UNINSTALL_ENABLED_FILE_GROUPS = 'OVESETUP_CORE/uninstallEnabledFileGroups' Line 536: REGISTER_UNINSTALL_GROUPS = 'OVESETUP_CORE/registerUninstallGroups' Line 537: CONFIRM_UNINSTALL_GROUPS = 'OVESETUP_CORE/confirmUninstallGroups' Line 538: UPGRADE_SUPPORTED_VERSIONS = 'OVESETUP_CORE/upgradeSupportedVersions' Line 539: OVIRT_SETUP_POST_INSTALL_CONFIG = 'OVESETUP_CORE/postinstallFile' why does it need to be configurable? Line 540: Line 541: @osetupattrs( Line 542: answerfile=True, Line 543: ) .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/postinstall.py Line 53: stage=plugin.Stages.STAGE_MISC, Line 54: priority=plugin.Stages.PRIORITY_LAST, Line 55: condition=lambda self: self.environment[ Line 56: osetupcons.CoreEnv.OVIRT_SETUP_POST_INSTALL_CONFIG Line 57: ] is not None when will it be none? Line 58: ) Line 59: def _misc(self): Line 60: filename = self.environment[ Line 61: osetupcons.CoreEnv.OVIRT_SETUP_POST_INSTALL_CONFIG -- To view, visit http://gerrit.ovirt.org/15957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3516d6b9b29d50844835bb67c0a4a3f5485aa21f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
