Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: add feedback image to webadmin
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
Line 87: <g:Anchor ui:field="logoutLink"
addStyleNames="{style.menuLink}" />
Line 88: </g:HTMLPanel>
Line 89:
Line 90: <div style="clear: both;" />
Line 91: <g:Image ui:field="feedbackImage"
addStyleNames="{style.obrand_feedbackImageStyle}" url="clear.cache.gif" />
are we sure that Image can accept the actual image as style? maybe we need a
different object?
Line 92: </g:HTMLPanel>
Line 93:
Line 94: <g:HTMLPanel addStyleNames="{style.lowerPanel}">
Line 95: <g:SimplePanel ui:field="searchPanelContainer"
addStyleNames="{style.searchPanel}" />
--
To view, visit http://gerrit.ovirt.org/15984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic804e1ec2a7365898db7013a09639a2096a76184
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
