Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: upgrade fqdn configuration
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 1101
Line 1102
Line 1103
Line 1104
Line 1105
how it can be? worse case we have this in defaults...
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/hostname.py
Line 328: fqdn = config.get('ENGINE_FQDN')
Line 329: if fqdn:
Line 330: self.environment[osetupcons.ConfigEnv.FQDN] = fqdn
Line 331: else:
Line 332: #Maybe we can read it from ca.pem ?
can this be? in which scenario?
Line 333: self.logger.error(
Line 334: _(
Line 335: 'Incomplete configuration detected: the '
Line 336: 'Host fully qualified DNS name is not
defined.'
--
To view, visit http://gerrit.ovirt.org/15979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8649f244b41493591bdbece1f28d306206ba40bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
