Yair Zaslavsky has posted comments on this change.
Change subject: filling the call stack in the audit log
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 233: // raise an alert that secondary agent was used
Line 234: AuditLogableBase logable = new AuditLogableBase();
Line 235: logable.setVdsId(getVds().getId());
Line 236: logable.addCustomValue("Operation",
getParameters().getAction().name());
Line 237:
logable.updateCallStackFromThrowable(vdsReturnValue.getExceptionObject());
Why do you want to add it here?
Line 238: AuditLogDirector.log(logable,
AuditLogType.VDS_ALERT_SECONDARY_AGENT_USED_FOR_FENCE_OPERATION);
Line 239: handleSpecificCommandActions();
Line 240: }
Line 241: else {
--
To view, visit http://gerrit.ovirt.org/15879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2231d602dfe50febfc932b24fe3a3e75d57ecb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
