Roy Golan has posted comments on this change.

Change subject: core: adding OvfHelper
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java
Line 16: 
Line 17:     public OvfHelper() {
Line 18:         ovfManager = new OvfManager();
Line 19:     }
Line 20: 
please add a javadoc here.
Line 21:     public VM readVmFromOvf(String ovf) throws OvfReaderException {
Line 22:         VM vm = new VM();
Line 23:         ArrayList<DiskImage> diskImages = new ArrayList<DiskImage>();
Line 24:         ArrayList<VmNetworkInterface> interfaces  = new 
ArrayList<VmNetworkInterface>();


-- 
To view, visit http://gerrit.ovirt.org/15626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to