Alona Kaplan has posted comments on this change.
Change subject: engine: introducing GetCapabilitiesCommand
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java
Line 31: }
Line 32: }
Line 33:
Line 34: @Override
Line 35: protected boolean canDoAction() {
Done
Line 36: if (!(validate(hostExists()) && validate(hostStatusValid()))){
Line 37: return false;
Line 38: }
Line 39: return true;
Line 48: }
Line 49:
Line 50: private ValidationResult hostStatusValid() {
Line 51: VDSStatus hostStatus = getVds().getStatus();
Line 52: if ((hostStatus != VDSStatus.Maintenance) && (hostStatus !=
VDSStatus.Up)
Done
Line 53: && (hostStatus != VDSStatus.NonOperational)) {
Line 54:
addCanDoActionMessage(VdcBllMessages.VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL);
Line 55: new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL);
Line 56: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 68: StartVds(121, ActionGroup.MANIPUTLATE_HOST, QuotaDependency.NONE),
Line 69: StopVds(122, ActionGroup.MANIPUTLATE_HOST, QuotaDependency.NONE),
Line 70: HandleVdsVersion(124, QuotaDependency.NONE),
Line 71: ChangeVDSCluster(125, ActionGroup.EDIT_HOST_CONFIGURATION, false,
QuotaDependency.NONE),
Line 72: RefreshHostCapabilities(126, ActionGroup.MANIPUTLATE_HOST,
QuotaDependency.NONE),
Done
Line 73: // Network
Line 74: UpdateNetworkToVdsInterface(149,
ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE),
Line 75: AttachNetworkToVdsInterface(150,
ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE),
Line 76: DetachNetworkFromVdsInterface(151,
ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE),
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 387: public VDS activate() {
Line 388: VDS vds = null;
Line 389: try {
Line 390: refreshHost(vds);
Line 391: } catch (java.lang.Exception e) {
Done
Line 392: log.infoFormat("Failed to activate VDS = {0} with error:
{1}.",
Line 393: getVdsId(), e.getMessage());
Line 394: }
Line 395:
--
To view, visit http://gerrit.ovirt.org/15640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba25577a7b66f3acedc3b32b258560861d19c621
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
