Alon Bar-Lev has posted comments on this change.
Change subject: packaging: fixed war removal on package removal (#977360)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/ovirt-engine-reports.spec.in
Line 103:
Line 104: %postun
Line 105: %update_maven_depmap
Line 106: if [ "$1" -eq 0 ]; then
Line 107: if [ -d /usr/share/ovirt-engine/%{name}.war ]; then
why not remove this unconditionally?
I don't understand... have we had duplicate? isn't the war name constant? if
not, we should have it constant to not have downstream/upstream changes.
Line 108: rm -rf /usr/share/ovirt-engine/%{name}.war
Line 109: rm -rf /var/lib/ovirt-engine/deployments/%{name}.war*
Line 110: fi
Line 111: if [ -f /etc/ovirt-engine/jrs-deployment.version ]; then
--
To view, visit http://gerrit.ovirt.org/16042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c2112f146aa2d6974dbc68d7aae16b325374062
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
