Yair Zaslavsky has posted comments on this change. Change subject: core: Migrate RuntimeInfo to use Batch Updates ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsDao.java Line 45: * Calls an update stored procedure multiple timse in a batch Line 46: * @param procedureName Line 47: * @param entities Line 48: */ Line 49: void updateAllInBatch(String procedureName, Collection<T> paramValues, EntityToMapSqlParameterMapper<T> mapper); I thought about the following: 1. updateAllInBatch(String porcefdureName, Collection<T> entities); 2. At the MassOperationsDaoDbFacadeImpl include an abstract method for the mapping (or use the entity). I prefer MassOPerationsDao to be clean from any MapSqlParameters. I also prefer this patch will be split to two: a. Introducing the new infra b. usage (I will show you how to do that). -- To view, visit http://gerrit.ovirt.org/16018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96dd3a2f407e36194c0ccf07a5a9c7e83be61d48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
