Eli Mesika has posted comments on this change.
Change subject: [WIP] core: Add vnic profiles to DB and entities
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File backend/manager/dbscripts/network_sp.sql
Line 1014:
----------------------------------------------------------------------
Line 1015: -- VNIC interface
Line 1016:
----------------------------------------------------------------------
Line 1017:
Line 1018: Create or replace FUNCTION Get_vm_interface_profile_by_id(v_id UUID)
Naming convention : works separated with underscores all lowercase or without
underscores with a Capital Letter on the beginning of each word. I know that
we have some names that do not obey to this rule but I am trying not to add
more ....
Please do that for all new SPs introduced here
Line 1019: RETURNS vnic_profiles
Line 1020: AS $procedure$
Line 1021: BEGIN
Line 1022:
Line 1094: BEGIN
Line 1095:
Line 1096: RETURN QUERY SELECT *
Line 1097: FROM vnic_profiles
Line 1098: WHERE network_id = v_network_id;
You will probably need to define an Index for that to prevent table scans
Line 1099:
Line 1100: END; $procedure$
Line 1101: LANGUAGE plpgsql;
Line 1102:
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0280_add_profile_to_network_interface.sql
Line 1: --Add vnic_profile id and name into vm_interface
Your table creation should go here as well....
Line 2: SELECT fn_db_add_column('vm_interface', 'vnic_profile_id', 'UUID NOT
NULL');
Line 3: SELECT fn_db_add_column('vm_interface', 'vnic_profile_name',
'VARCHAR(50) NOT NULL');
Line 4:
Line 5: ALTER TABLE vm_interface ADD CONSTRAINT FK_vm_interface_vnic_profile_id
FOREIGN KEY(vnic_profile_id)
Line 48: ------------------------------------------------
Line 49: --- Update existing roles with new Action Groups
Line 50: ------------------------------------------------
Line 51: -- Add ActionGroup 1203 (CONFIGURE_NETWORK_VNIC_PROFILE) to any role
which contains ActionGroup 703 (CONFIGURE_STORAGE_POOL_NETWORK)
Line 52: INSERT INTO roles_groups (role_id, action_group_id)
All rows should be indented with 4 blanks to distinguish that they are part of
this functions
Line 53: SELECT DISTINCT role_id, 1203
Line 54: FROM roles_groups a
Line 55: WHERE NOT EXISTS (SELECT 1
Line 56: FROM roles_groups b
--
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
