Roy Golan has posted comments on this change.

Change subject: core: Add supportedEmulatedMachines to Host model cluster
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File 
backend/manager/dbscripts/upgrade/03_03_0320_add_emulated_machine_to_host_and_cluster.sql
Line 1: SELECT fn_db_add_column('vds_dynamic', 'supported_emulated_machines', 
'character varying(255)');
I'll increase the size of the field. a Host may have a big list with long values


Line 1: SELECT fn_db_add_column('vds_dynamic', 'supported_emulated_machines', 
'character varying(255)');
Line 2: SELECT fn_db_add_column('vds_groups', 'emulated_machine', 'character 
varying(40)');
maybe increase this as well


-- 
To view, visit http://gerrit.ovirt.org/15905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib12ef4a5289a72c1ea5a117c9c4f0435a7b6bafe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to