Alon Bar-Lev has posted comments on this change.
Change subject: pki: introduce the EngineEncryptionUtils
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
Line 151: private void createConcreteSSLSocketFactory() throws
NotificationServiceException {
Line 152: try {
Line 153: String sslProtocol =
prop.getProperty(NotificationProperties.SSL_PROTOCOL);
Line 154: SSLContext ctx = SSLContext.getInstance(sslProtocol);
Line 155: ctx.init(null, EngineEncryptionUtils.getTrustManagers(),
null);
this is a change... the previous version tried to extract trust information
from the keystore while this is available at the truststore.
Line 156: sslFactory = ctx.getSocketFactory();
Line 157: } catch (Exception e) {
Line 158: throw new NotificationServiceException("Failed to create
SSL factory when running with SSL mode.", e);
Line 159: }
--
To view, visit http://gerrit.ovirt.org/16088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10af516c2f35bb853ccae42a03e3ec4b98ce5efb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
