Roy Golan has posted comments on this change.
Change subject: core: remove vmType related logic
......................................................................
Patch Set 15: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 94: setStorageDomainId(getParameters().getStorageDomainId());
Line 95: if (parameters.getVmStaticData() != null) {
Line 96: setVmTemplateId(parameters.getVmStaticData().getVmtGuid());
Line 97:
Line 98: // API backward compatibility
nice
Line 99: if (parameters.isSoundDeviceEnabled() == null) {
Line 100:
parameters.setSoundDeviceEnabled(parameters.getVmStaticData().getVmType() ==
VmType.Desktop);
Line 101: }
Line 102: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
Line 34: }
Line 35:
Line 36: @Override
Line 37: protected List<Class<?>> getValidationGroups() {
Line 38: addValidationGroup(DesktopVM.class);
* remove DesktopVM class
* remove the group from teh validation at VmBase numberofmonitors (it will now
be genral)
* delete this method - ytou don't need to override it
Line 39: return super.getValidationGroups();
Line 40: }
Line 41:
Line 42: /**
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
Line 34: message =
"ACTION_TYPE_FAILED_DESCRIPTION_MAY_NOT_CONTAIN_SPECIAL_CHARS")
Line 35: private String _description;
Line 36:
Line 37: private boolean publicUse = false;
Line 38: private Boolean soundDeviceEnabled;
pls document the reason for this is a boxed type
Line 39:
Line 40: public AddVmTemplateParameters(VmStatic masterVm, String name,
String description) {
Line 41: _masterVm = masterVm;
Line 42: _name = name;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java
Line 7: public class UpdateVmTemplateParameters extends
VmTemplateParametersBase {
Line 8: private static final long serialVersionUID = 7250355162926369307L;
Line 9: @Valid
Line 10: private VmTemplate _vmTemplate;
Line 11: private Boolean soundDeviceEnabled;
pls doc...
Line 12:
Line 13: public UpdateVmTemplateParameters(VmTemplate vmTemplate) {
Line 14: _vmTemplate = vmTemplate;
Line 15: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
Line 31: * it is not meant to be removing the watchdog, rest-api will
simply call watchdog commands directly.
Line 32: * Default is false so to avoid breaking rest-api.
Line 33: */
Line 34: private boolean updateWatchdog = false;
Line 35: private Boolean soundDeviceEnabled;
you know...
Line 36:
Line 37: public VmManagementParametersBase() {
Line 38: }
Line 39:
--
To view, visit http://gerrit.ovirt.org/14963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d6e5bbd66c4d67ec37326b545b65f086600169
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
