Michael Pasternak has posted comments on this change. Change subject: engine: add comment field to VM,Template,Pool [6] ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) please add: 1. ...MapperTest entry for the comment field 2. rsdl_metadat.yaml records for the add()/update() .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1932: <xs:element ref="domain" minOccurs="0" maxOccurs="1"/> Line 1933: <xs:element ref="usb" minOccurs="0" maxOccurs="1"/> Line 1934: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1935: <!-- also rel="cdroms/disks/nics" links, see Devices below --> Line 1936: <xs:element name="comment" type="xs:string" minOccurs="0" maxOccurs="1"/> BaseResource that template inherits from already has comment field (worth rebasing). Line 1937: </xs:sequence> Line 1938: </xs:extension> Line 1939: </xs:complexContent> Line 1940: </xs:complexType> Line 2136: <xs:element name="guest_info" type="GuestInfo" minOccurs="0" maxOccurs="1"/> Line 2137: <xs:element ref="quota" minOccurs="0" maxOccurs="1"/> Line 2138: <xs:element ref="usb" minOccurs="0" maxOccurs="1"/> Line 2139: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 2140: <xs:element name="comment" type="xs:string" minOccurs="0" maxOccurs="1"/> same Line 2141: <xs:element ref="vmpool" minOccurs="0" maxOccurs="1"> Line 2142: <xs:annotation> Line 2143: <xs:appinfo> Line 2144: <jaxb:property name="VmPool"/> Line 2279: <xs:element name="size" type="xs:int" minOccurs="0"/> Line 2280: <xs:element ref="cluster" minOccurs="0" maxOccurs="1"/> Line 2281: <xs:element ref="template" minOccurs="0" maxOccurs="1"/> Line 2282: <xs:element name="prestarted_vms" type="xs:int" minOccurs="0"/> Line 2283: <xs:element name="comment" type="xs:string" minOccurs="0" maxOccurs="1"/> same Line 2284: </xs:sequence> Line 2285: </xs:extension> Line 2286: </xs:complexContent> Line 2287: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/15643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f8c0af979e9ec4724284d92f79a0b688e961425 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
